From: Edwin Kofler Date: Thu, 20 Apr 2023 22:38:00 +0000 (+0900) Subject: completion: suppress unwanted unescaping of `read` X-Git-Tag: v2.41.0-rc0~48^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=197152098a257998b14e04b85b28216bd68f5b9c;p=thirdparty%2Fgit.git completion: suppress unwanted unescaping of `read` The function `__git_eread`, which reads the first line from the file, calls the `read` builtin without passing the flag option `-r`. When the `read` builtin is called without the flag `-r`, it processes the backslash escaping in the text that it reads. For this reason, it is generally considered the best practice to always use the `read` builtin with flag `-r` unless one intensionally processes the backslash escaping. For the present case in git-prompt.sh, in fact, all the occurrences of the calls of `__git_eread` intend to read the literal content of the first lines. To make it read the first line literally, pass the flag `-r` to the `read` builtin in the function `__git_eread`. Signed-off-by: Edwin Kofler Signed-off-by: Koichi Murase Signed-off-by: Junio C Hamano --- diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh index 57972c2845..b234bfefda 100644 --- a/contrib/completion/git-prompt.sh +++ b/contrib/completion/git-prompt.sh @@ -300,7 +300,7 @@ __git_ps1_colorize_gitstring () # variable, in that order. __git_eread () { - test -r "$1" && IFS=$'\r\n' read "$2" <"$1" + test -r "$1" && IFS=$'\r\n' read -r "$2" <"$1" } # see if a cherry-pick or revert is in progress, if the user has committed a