From: lpsolit%gmail.com <> Date: Thu, 30 Jun 2005 05:07:31 +0000 (+0000) Subject: Bug 298024: Incorrect group control check in sanitycheck.cgi - Patch by Frédéric... X-Git-Tag: bugzilla-2.18.2~9 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=19877bcbd7f4f04fd9c06094ae1e5ca9d7a50e8c;p=thirdparty%2Fbugzilla.git Bug 298024: Incorrect group control check in sanitycheck.cgi - Patch by Frédéric Buclin r=joel a=myk --- diff --git a/sanitycheck.cgi b/sanitycheck.cgi index da5fd58aef..de0a879ab0 100755 --- a/sanitycheck.cgi +++ b/sanitycheck.cgi @@ -774,7 +774,6 @@ if ($c) { Status("Checking for bugs with groups violating their product's group controls"); BugCheck("bugs INNER JOIN bug_group_map ON bugs.bug_id = bug_group_map.bug_id - INNER JOIN groups ON bug_group_map.group_id = groups.id LEFT JOIN group_control_map ON bugs.product_id = group_control_map.product_id AND bug_group_map.group_id = group_control_map.group_id WHERE ((group_control_map.membercontrol = " . CONTROLMAPNA . ") @@ -785,12 +784,13 @@ BugCheck("bugs (set member control to SHOWN)'); BugCheck("bugs - INNER JOIN bug_group_map ON bugs.bug_id = bug_group_map.bug_id - INNER JOIN groups ON bug_group_map.group_id = groups.id - LEFT JOIN group_control_map ON bugs.product_id = group_control_map.product_id - AND bug_group_map.group_id = group_control_map.group_id + INNER JOIN group_control_map ON bugs.product_id = group_control_map.product_id + INNER JOIN groups ON group_control_map.group_id = groups.id + LEFT JOIN bug_group_map ON bugs.bug_id = bug_group_map.bug_id + AND group_control_map.group_id = bug_group_map.group_id WHERE group_control_map.membercontrol = " . CONTROLMAPMANDATORY . " - AND bug_group_map.group_id IS NULL", + AND bug_group_map.group_id IS NULL + AND groups.isactive != 0", "Are missing groups required for their products");