From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Thu, 3 Mar 2022 12:11:29 +0000 (+0100)
Subject: optimize: incorrect assert() for unexpected expression type
X-Git-Tag: v1.0.3~58
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=19960c8d391509ac34b2ff527786ce8b9d832a7b;p=thirdparty%2Fnftables.git

optimize: incorrect assert() for unexpected expression type

assert(1) is noop, this should be assert(0) instead.

Fixes: 561aa3cfa8da ("optimize: merge verdict maps with same lookup key")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/src/optimize.c b/src/optimize.c
index af075da4..6ba7e5a1 100644
--- a/src/optimize.c
+++ b/src/optimize.c
@@ -362,11 +362,11 @@ static void merge_verdict_stmts(const struct optimize_ctx *ctx,
 				merge_vmap(ctx, stmt_a, stmt_b);
 				break;
 			default:
-				assert(1);
+				assert(0);
 			}
 			break;
 		default:
-			assert(1);
+			assert(0);
 			break;
 		}
 	}
@@ -385,7 +385,7 @@ static void merge_stmts(const struct optimize_ctx *ctx,
 		merge_verdict_stmts(ctx, from, to, merge, stmt_a);
 		break;
 	default:
-		assert(1);
+		assert(0);
 	}
 }