From: Joel Brobecker <brobecker@adacore.com>
Date: Mon, 2 Feb 2015 03:20:58 +0000 (+0400)
Subject: [Ada] pspace_data->sym_cache is always NULL
X-Git-Tag: gdb-7.9.0-release~35
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=19a5737950b966d0ff3e50c01bb43742a870bb9e;p=thirdparty%2Fbinutils-gdb.git

[Ada] pspace_data->sym_cache is always NULL

The Ada symbol cache has been designed to have one instance of that
of that cache per program space, and for each instance to be created
on-demand. ada_get_symbol_cache is the function responsible for both
lookup and creation on demand.

Unfortunately, ada_get_symbol_cache forgot to store the reference
to newly created caches, thus causing it to:
  - Leak old caches;
  - Allocate a new cache each time the cache is being searched or
    a new entry is to be inserted.

This patch fixes the issue by avoiding the use of the local variable,
which indirectly allowed the bug to happen. We manipulate the reference
in the program-space data instead.

gdb/ChangeLog:

        PR gdb/17854:
        * ada-lang.c (ada_get_symbol_cache): Set pspace_data->sym_cache
        when allocating a new one.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e14489be24c..2434e2f87c7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2015-02-02  Joel Brobecker  <brobecker@adacore.com>
+
+	PR gdb/17854:
+	* ada-lang.c (ada_get_symbol_cache): Set pspace_data->sym_cache
+	when allocating a new one.
+
 2015-01-31  Joel Brobecker  <brobecker@adacore.com>
 
 	PR symtab/17855
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index ec066933b53..2dc541937d3 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -4393,15 +4393,14 @@ static struct ada_symbol_cache *
 ada_get_symbol_cache (struct program_space *pspace)
 {
   struct ada_pspace_data *pspace_data = get_ada_pspace_data (pspace);
-  struct ada_symbol_cache *sym_cache = pspace_data->sym_cache;
 
-  if (sym_cache == NULL)
+  if (pspace_data->sym_cache == NULL)
     {
-      sym_cache = XCNEW (struct ada_symbol_cache);
-      ada_init_symbol_cache (sym_cache);
+      pspace_data->sym_cache = XCNEW (struct ada_symbol_cache);
+      ada_init_symbol_cache (pspace_data->sym_cache);
     }
 
-  return sym_cache;
+  return pspace_data->sym_cache;
 }
 
 /* Clear all entries from the symbol cache.  */