From: Daniel Stenberg <daniel@haxx.se>
Date: Sun, 22 Oct 2023 09:22:08 +0000 (+0200)
Subject: http2: provide an error callback and failf the message
X-Git-Tag: curl-8_5_0~207
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=19a82c12c098ec201fe3a03c6b5dcc8962843864;p=thirdparty%2Fcurl.git

http2: provide an error callback and failf the message

Getting nghttp2's error message helps users understand what's going
on. For example when the connection is brought down due a forbidden
header is used - as that header is then not displayed by curl itself.

Example:

  curl: (92) Invalid HTTP header field was received: frame type: 1,
  stream: 1, name: [upgrade], value: [h2,h2c]

Ref: #12172
Closes #12179
---

diff --git a/lib/http2.c b/lib/http2.c
index d4fcb26531..a989280f3e 100644
--- a/lib/http2.c
+++ b/lib/http2.c
@@ -1607,10 +1607,10 @@ static int error_callback(nghttp2_session *session,
                           size_t len,
                           void *userp)
 {
+  struct Curl_cfilter *cf = userp;
+  struct Curl_easy *data = CF_DATA_CURRENT(cf);
   (void)session;
-  (void)msg;
-  (void)len;
-  (void)userp;
+  failf(data, "%.*s", (int)len, msg);
   return 0;
 }
 #endif