From: mrs Date: Sun, 10 Apr 2011 18:13:23 +0000 (+0000) Subject: 2011-04-10 Jim Meyering X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=19bff7fe624209f0ffe8d6cac8a7a735e9c507f5;p=thirdparty%2Fgcc.git 2011-04-10 Jim Meyering Avoid memory overrun in a test leading to potential double-free. * testsuite/test-expandargv.c (writeout_test): Fix off-by-one error: i.e., do copy the trailing NUL byte. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@172246 138bc75d-0d04-0410-961f-82ee72b054a4 --- diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog index f6138b69e248..a15ffa59d289 100644 --- a/libiberty/ChangeLog +++ b/libiberty/ChangeLog @@ -1,3 +1,9 @@ +2011-04-10 Jim Meyering + + Avoid memory overrun in a test leading to potential double-free. + * testsuite/test-expandargv.c (writeout_test): Fix off-by-one error: + i.e., do copy the trailing NUL byte. + 2011-03-31 Tristan Gingold * makefile.vms (OBJS): Add filename_cmp.obj diff --git a/libiberty/testsuite/test-expandargv.c b/libiberty/testsuite/test-expandargv.c index c16a0322a6c4..57b96b3ff977 100644 --- a/libiberty/testsuite/test-expandargv.c +++ b/libiberty/testsuite/test-expandargv.c @@ -204,7 +204,7 @@ writeout_test (int test, const char * test_data) if (parse == NULL) fatal_error (__LINE__, "Failed to malloc parse.", errno); - memcpy (parse, test_data, sizeof (char) * len); + memcpy (parse, test_data, sizeof (char) * (len + 1)); /* Run all possible replaces */ run_replaces (parse);