From: Jesse Zhang <jesse.zhang@amd.com>
Date: Thu, 9 May 2024 03:09:37 +0000 (+0800)
Subject: drm/amd/pm: fix enum feature compared against 0
X-Git-Tag: v6.11-rc1~141^2~25^2~227
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1a296827feef4dbad1e2863b0e2d7d7d8afc781a;p=thirdparty%2Fkernel%2Flinux.git

drm/amd/pm: fix enum feature compared against 0

This less-than-zero comparison of an unsigned value is never true. feature < 0U

Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
Reviewed-by: Yang Wang <kevinyang.wang@amd.com>
Reviewed-by: Tim Huang <Tim.Huang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index ac17e44ba85b8..602aa69412310 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -760,7 +760,7 @@ static const char *__smu_feature_names[] = {
 static const char *smu_get_feature_name(struct smu_context *smu,
 					enum smu_feature_mask feature)
 {
-	if (feature < 0 || feature >= SMU_FEATURE_COUNT)
+	if (feature >= SMU_FEATURE_COUNT)
 		return "unknown smu feature";
 	return __smu_feature_names[feature];
 }