From: Jim Fehlig <jfehlig@suse.com>
Date: Fri, 8 Dec 2023 01:38:22 +0000 (-0700)
Subject: remote: Fix cached hypervisor type
X-Git-Tag: v10.0.0-rc1~110
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1a2f33cb593e6bf4913d97143bf76d5e7f866912;p=thirdparty%2Flibvirt.git

remote: Fix cached hypervisor type

Commit 501825011c switched the remote driver to using g_auto, but missed
one case of needing to steal a pointer holding the hypervisor type.
Without it, memory is freed and the output of 'virsh version' has random
output

Compiled against library: libvirt 10.0.0
Using library: libvirt 10.0.0
Using API: ��%�U 10.0.0
Running hypervisor: ��U 8.1.3

Ths change also fixes random SIGABRT from perl processes running
libvirt-tck tests.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index c4831db6cd..132d0194c6 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -1408,7 +1408,7 @@ remoteConnectGetType(virConnectPtr conn)
         return NULL;
 
     /* Stash. */
-    return priv->type = ret.type;
+    return priv->type = g_steal_pointer(&ret.type);
 }
 
 static int remoteConnectIsSecure(virConnectPtr conn)