From: Willy Tarreau <w@1wt.eu>
Date: Wed, 14 Oct 2020 10:13:51 +0000 (+0200)
Subject: BUG/MEDIUM: deinit: check fdtab before fdtab[fd].owner
X-Git-Tag: v2.3-dev7~43
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1a3770cbc7de5a00f3aab3238a587468e419c7f4;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: deinit: check fdtab before fdtab[fd].owner

When running a pure config check (haproxy -c) we go through the deinit
phase without having allocated fdtab, so we can't blindly dereference
it. The issue was added by recent commit ae7bc4a23 ("MEDIUM: deinit:
close all receivers/listeners before scanning proxies"), no backport is
needed.
---

diff --git a/src/haproxy.c b/src/haproxy.c
index 3bdcba7b82..4ef79bc27a 100644
--- a/src/haproxy.c
+++ b/src/haproxy.c
@@ -2452,7 +2452,7 @@ void deinit(void)
 	protocol_unbind_all();
 
 	for (cur_fd = 0; cur_fd < global.maxsock; cur_fd++) {
-		if (!fdtab[cur_fd].owner)
+		if (!fdtab || !fdtab[cur_fd].owner)
 			continue;
 
 		if (fdtab[cur_fd].iocb == listener_accept) {