From: Howard Chu <hyc@openldap.org>
Date: Fri, 15 Mar 2024 01:44:56 +0000 (+0000)
Subject: ITS#10185 autogroup: check for invalid memberURL filter
X-Git-Tag: OPENLDAP_REL_ENG_2_6_8~44
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1a5007f38633fd17b18f7e22d999fb4e998b336a;p=thirdparty%2Fopenldap.git

ITS#10185 autogroup: check for invalid memberURL filter
---

diff --git a/contrib/slapd-modules/autogroup/autogroup.c b/contrib/slapd-modules/autogroup/autogroup.c
index 3c40daf8ef..2e1829be6e 100644
--- a/contrib/slapd-modules/autogroup/autogroup.c
+++ b/contrib/slapd-modules/autogroup/autogroup.c
@@ -684,6 +684,10 @@ autogroup_add_group( Operation *op, autogroup_info_t *agi, autogroup_def_t *agd,
 			if ( lud->lud_filter != NULL ) {
 				ber_str2bv( lud->lud_filter, 0, 1, &agf->agf_filterstr);
 				agf->agf_filter = str2filter( lud->lud_filter );
+				if ( !agf->agf_filter ) {
+					Debug( LDAP_DEBUG_TRACE, "autogroup_add_group: URL filter is invalid <%s>\n", bv->bv_val );
+					goto cleanup;
+				}
 			} else {
 				Debug( LDAP_DEBUG_TRACE, "autogroup_add_group: URL filter is missing <%s>\n", bv->bv_val );
 				/* FIXME: error? */