From: Maxim Mikityanskiy Date: Tue, 12 Apr 2022 18:59:53 +0000 (+0300) Subject: net/mlx5e: Remove the duplicating check for striding RQ when enabling LRO X-Git-Tag: v6.0-rc1~141^2~123^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1a55048674379f9b093e0a6dbef586d28b55f9ae;p=thirdparty%2Fkernel%2Flinux.git net/mlx5e: Remove the duplicating check for striding RQ when enabling LRO LRO requires striding RQ and checks that it's enabled at two places: mlx5e_fix_features and set_feature_lro. This commit keeps only one check at mlx5e_fix_features and removes the duplicating one in set_feature_lro. Signed-off-by: Maxim Mikityanskiy Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index be84f800e1221..cac4022ba7f31 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -3595,12 +3595,6 @@ static int set_feature_lro(struct net_device *netdev, bool enable) mutex_lock(&priv->state_lock); cur_params = &priv->channels.params; - if (enable && !MLX5E_GET_PFLAG(cur_params, MLX5E_PFLAG_RX_STRIDING_RQ)) { - netdev_warn(netdev, "can't set LRO with legacy RQ\n"); - err = -EINVAL; - goto out; - } - new_params = *cur_params; if (enable)