From: Harry Sintonen <sintonen@iki.fi>
Date: Wed, 4 May 2022 21:33:17 +0000 (+0200)
Subject: gskit_connect_step1: fixed bogus setsockopt calls
X-Git-Tag: curl-7_83_1~37
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1a78051732e35ed3c7a0707d3cdbf13857f43553;p=thirdparty%2Fcurl.git

gskit_connect_step1: fixed bogus setsockopt calls

setsockopt takes a reference to value, not value. With the current
code this just leads to -1 return value with errno EFAULT.

Closes #8793
---

diff --git a/lib/vtls/gskit.c b/lib/vtls/gskit.c
index 43456172a3..7a65f92f20 100644
--- a/lib/vtls/gskit.c
+++ b/lib/vtls/gskit.c
@@ -775,13 +775,13 @@ static CURLcode gskit_connect_step1(struct Curl_easy *data,
     BACKEND->localfd = sockpair[0];
     BACKEND->remotefd = sockpair[1];
     setsockopt(BACKEND->localfd, SOL_SOCKET, SO_RCVBUF,
-               (void *) sobufsize, sizeof(sobufsize));
+               (void *) &sobufsize, sizeof(sobufsize));
     setsockopt(BACKEND->remotefd, SOL_SOCKET, SO_RCVBUF,
-               (void *) sobufsize, sizeof(sobufsize));
+               (void *) &sobufsize, sizeof(sobufsize));
     setsockopt(BACKEND->localfd, SOL_SOCKET, SO_SNDBUF,
-               (void *) sobufsize, sizeof(sobufsize));
+               (void *) &sobufsize, sizeof(sobufsize));
     setsockopt(BACKEND->remotefd, SOL_SOCKET, SO_SNDBUF,
-               (void *) sobufsize, sizeof(sobufsize));
+               (void *) &sobufsize, sizeof(sobufsize));
     curlx_nonblock(BACKEND->localfd, TRUE);
     curlx_nonblock(BACKEND->remotefd, TRUE);
   }