From: Simon Marchi <simon.marchi@efficios.com>
Date: Wed, 24 Apr 2024 02:52:00 +0000 (+0000)
Subject: gdb: include extract-store-integer.h in charset.c when PHONY_ICONV
X-Git-Tag: gdb-15-branchpoint~265
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1a7f925ea20c82fc9899f41d21df8e21dcae3169;p=thirdparty%2Fbinutils-gdb.git

gdb: include extract-store-integer.h in charset.c when PHONY_ICONV

When building on a system where "phony iconv" is used (NetBSD in this
case, not sure why), I get:

      CXX    charset.o
    /home/smarchi/src/binutils-gdb/gdb/charset.c: In function 'size_t phony_iconv(int, const char**, size_t*, char**, size_t*)':
    /home/smarchi/src/binutils-gdb/gdb/charset.c:140:8: error: 'extract_unsigned_integer' was not declared in this scope
          = extract_unsigned_integer ((const gdb_byte *)*inbuf, 4, endian);
            ^~~~~~~~~~~~~~~~~~~~~~~~
    /home/smarchi/src/binutils-gdb/gdb/charset.c:140:8: note: suggested alternative: 'btrace_insn_number'
          = extract_unsigned_integer ((const gdb_byte *)*inbuf, 4, endian);
            ^~~~~~~~~~~~~~~~~~~~~~~~
            btrace_insn_number

Add the necessary include.

Change-Id: I10b967584645961c86167a8395d88929a42bef03
---

diff --git a/gdb/charset.c b/gdb/charset.c
index 4c1debef614..17a9ca81b2e 100644
--- a/gdb/charset.c
+++ b/gdb/charset.c
@@ -71,6 +71,8 @@
 
 #ifdef PHONY_ICONV
 
+#include "extract-store-integer.h"
+
 /* Provide a phony iconv that does as little as possible.  Also,
    arrange for there to be a single available character set.  */