From: Peter Krempa <pkrempa@redhat.com>
Date: Wed, 13 Mar 2024 16:55:53 +0000 (+0100)
Subject: virsh: cmdDomdisplayReload: Require option name for --type
X-Git-Tag: v10.2.0-rc2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1a883c9a7cdcd5a286333a68bf196cec9205d50c;p=thirdparty%2Flibvirt.git

virsh: cmdDomdisplayReload: Require option name for --type

As this command was introduced in this release add the flag requiring to
pass optionname.

This is needed to actually disallow positional parsing of the value
despite documenting that the flag name is required.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 115b802c45..28d430bf92 100644
--- a/docs/manpages/virsh.rst
+++ b/docs/manpages/virsh.rst
@@ -1790,7 +1790,7 @@ domdisplay-reload
 
 ::
 
-    domdisplay-reload <domain> [[--type] <type>]
+    domdisplay-reload <domain> [--type <type>]
 
 Reload the domain's graphical display. This reloads its TLS certificates
 without restarting the domain. ``type`` can be any constant from the
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 35809a866b..cd37828660 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -13290,6 +13290,7 @@ static const vshCmdOptDef opts_domdisplay_reload[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(0),
     {.name = "type",
      .type = VSH_OT_INT,
+     .flags = VSH_OFLAG_REQ_OPT,
      .help = N_("graphics display type")
     },
     {.name = NULL}