From: Sami Kerola <kerolasa@iki.fi>
Date: Sun, 21 Jul 2019 18:12:03 +0000 (+0100)
Subject: login: simplify string handling
X-Git-Tag: v2.35-rc1~299
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1aaee548e3cbe00a084103792b03605182eefd04;p=thirdparty%2Futil-linux.git

login: simplify string handling

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/login-utils/login.c b/login-utils/login.c
index ce112b54eb..6b9d27e3ef 100644
--- a/login-utils/login.c
+++ b/login-utils/login.c
@@ -1355,10 +1355,7 @@ int main(int argc, char **argv)
 
 	/* if the shell field has a space: treat it like a shell script */
 	if (strchr(pwd->pw_shell, ' ')) {
-		buff = xmalloc(strlen(pwd->pw_shell) + 6);
-
-		strcpy(buff, "exec ");
-		strcat(buff, pwd->pw_shell);
+		xasprintf(&buff, "exec %s", pwd->pw_shell);
 		childArgv[childArgc++] = "/bin/sh";
 		childArgv[childArgc++] = "-sh";
 		childArgv[childArgc++] = "-c";