From: John Snow Date: Fri, 8 Jul 2022 15:34:53 +0000 (-0400) Subject: tests/vm: use 'cp' instead of 'ln' for temporary vm images X-Git-Tag: v7.1.0-rc0~13^2~12 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1ab330eae5bc191ed165adc6937fba20ee767b56;p=thirdparty%2Fqemu.git tests/vm: use 'cp' instead of 'ln' for temporary vm images If the initial setup fails, you've permanently altered the state of the downloaded image in an unknowable way. Use 'cp' like our other test setup scripts do. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrangé Reviewed-by: Richard Henderson Message-Id: <20220708153503.18864-3-jsnow@redhat.com> Signed-off-by: Thomas Huth --- diff --git a/tests/vm/centos b/tests/vm/centos index 5c7bc1c1a9a..be4f6ff2f14 100755 --- a/tests/vm/centos +++ b/tests/vm/centos @@ -34,7 +34,7 @@ class CentosVM(basevm.BaseVM): def build_image(self, img): cimg = self._download_with_cache("https://cloud.centos.org/centos/8/x86_64/images/CentOS-8-GenericCloud-8.3.2011-20201204.2.x86_64.qcow2") img_tmp = img + ".tmp" - subprocess.check_call(["ln", "-f", cimg, img_tmp]) + subprocess.check_call(['cp', '-f', cimg, img_tmp]) self.exec_qemu_img("resize", img_tmp, "50G") self.boot(img_tmp, extra_args = ["-cdrom", self.gen_cloud_init_iso()]) self.wait_ssh()