From: Michael Tremer <michael.tremer@ipfire.org>
Date: Tue, 12 Sep 2023 17:43:38 +0000 (+0000)
Subject: util: Fix potential double-free on error
X-Git-Tag: 0.9.29~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1b0f4ce1ce58f2b47e2ae660569c9129b5b8ff9f;p=pakfire.git

util: Fix potential double-free on error

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/util.c b/src/libpakfire/util.c
index 095df5a88..676f40fc7 100644
--- a/src/libpakfire/util.c
+++ b/src/libpakfire/util.c
@@ -395,10 +395,8 @@ int pakfire_read_file_into_buffer(FILE* f, char** buffer, size_t* len) {
 
 	// Check we encountered any errors
 	r = ferror(f);
-	if (r) {
-		free(*buffer);
+	if (r)
 		return r;
-	}
 
 	// Terminate the buffer
 	(*buffer)[*len] = '\0';