From: Joel Rosdahl <joel@rosdahl.net>
Date: Sun, 15 Aug 2021 19:29:40 +0000 (+0200)
Subject: refactor: Return from process_main_options instead of exiting
X-Git-Tag: v4.4~16
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1b144681666a42ac3786742cf46c48a747d3d6a2;p=thirdparty%2Fccache.git

refactor: Return from process_main_options instead of exiting
---

diff --git a/src/core/mainoptions.cpp b/src/core/mainoptions.cpp
index 3b61eaa8c..5bd02986e 100644
--- a/src/core/mainoptions.cpp
+++ b/src/core/mainoptions.cpp
@@ -452,7 +452,7 @@ process_main_options(int argc, const char* const* argv)
 
     case 'h': // --help
       PRINT(stdout, USAGE_TEXT, CCACHE_NAME, CCACHE_NAME);
-      exit(EXIT_SUCCESS);
+      return EXIT_SUCCESS;
 
     case 'k': // --get-config
       PRINT(stdout, "{}\n", config.get_string_value(arg));
@@ -532,7 +532,7 @@ process_main_options(int argc, const char* const* argv)
 
     case 'V': // --version
       PRINT_RAW(stdout, get_version_text());
-      exit(EXIT_SUCCESS);
+      break;
 
     case 'x': // --show-compression
     {
@@ -570,11 +570,11 @@ process_main_options(int argc, const char* const* argv)
 
     default:
       PRINT(stderr, USAGE_TEXT, CCACHE_NAME, CCACHE_NAME);
-      exit(EXIT_FAILURE);
+      return EXIT_FAILURE;
     }
   }
 
-  return 0;
+  return EXIT_SUCCESS;
 }
 
 } // namespace core