From: Michael Tremer <michael.tremer@ipfire.org>
Date: Fri, 24 Mar 2023 16:17:22 +0000 (+0000)
Subject: archive: read: Correctly fail if we cannot find a file
X-Git-Tag: 0.9.29~215
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1b1cf5f543868eda21e6f03a8081872724530773;p=pakfire.git

archive: read: Correctly fail if we cannot find a file

The routine did not properly clear up the cookie after it could not find
a file in the archive.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/archive.c b/src/libpakfire/archive.c
index ff83af823..34d1f9869 100644
--- a/src/libpakfire/archive.c
+++ b/src/libpakfire/archive.c
@@ -692,10 +692,11 @@ PAKFIRE_EXPORT FILE* pakfire_archive_read(struct pakfire_archive* archive, const
 
 	// Nothing found
 	if (!f) {
+		ERROR(archive->pakfire, "Could not find /%s\n", path);
+
 		// No such file or directory
 		errno = ENOENT;
-
-		ERROR(archive->pakfire, "Could not find /%s: %m\n", path);
+		goto ERROR;
 	}
 
 	return f;