From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Mon, 27 Aug 2018 07:35:47 +0000 (+0300)
Subject: lib: connection - Clarify logging of incoming connections
X-Git-Tag: 2.3.4~74
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1b2cc46c2344ff0bc041bc0e3bac99b93bd30a82;p=thirdparty%2Fdovecot%2Fcore.git

lib: connection - Clarify logging of incoming connections

Don't log "Client connected" for both incoming and outgoing connections.
---

diff --git a/src/lib/connection.c b/src/lib/connection.c
index 9b4c0bc3de..ed3d129ed0 100644
--- a/src/lib/connection.c
+++ b/src/lib/connection.c
@@ -261,7 +261,10 @@ void connection_init_server(struct connection_list *list,
 
 	struct event_passthrough *e = event_create_passthrough(conn->event)->
 		set_name("client_connection_connected");
-	e_debug(e->event(), "Client connected");
+	/* fd_out differs from fd_in only for stdin/stdout. Keep the logging
+	   output nice and clean by logging only the fd_in. If it's 0, it'll
+	   also be obvious that fd_out=1. */
+	e_debug(e->event(), "Server accepted connection (fd=%d)", fd_in);
 
 	connection_init_streams(conn);
 }