From: Chris Wilson Date: Wed, 16 Jan 2019 15:54:21 +0000 (+0000) Subject: drm/i915: Limit the for_each_set_bit() to the valid range X-Git-Tag: v5.1-rc1~117^2~19^2~49 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1b4bd5c4a663663e8dd4b7b1c5f8565626eb068b;p=thirdparty%2Fkernel%2Flinux.git drm/i915: Limit the for_each_set_bit() to the valid range Let static analyzers (smatch) know that we are not going to wander off the end of the array by providing a tight upper bound: drivers/gpu/drm/i915/intel_display.c:9532 hsw_get_transcoder_state() error: buffer overflow 'dev_priv->__info.trans_offsets' 6 <= 31 References: 0716931a82b4 ("drm/i915/icl: fix transcoder state readout") Signed-off-by: Chris Wilson Cc: Jani Nikula Cc: Ville Syrjala Cc: Imre Deak Cc: Madhav Chauhan Reviewed-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20190116155421.7660-1-chris@chris-wilson.co.uk --- diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 8d6d7ae311f44..9a6fbce1cafc3 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9526,7 +9526,9 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc, * XXX: Do intel_display_power_get_if_enabled before reading this (for * consistency and less surprising code; it's in always on power). */ - for_each_set_bit(panel_transcoder, &panel_transcoder_mask, 32) { + for_each_set_bit(panel_transcoder, + &panel_transcoder_mask, + ARRAY_SIZE(INTEL_INFO(dev_priv)->trans_offsets)) { enum pipe trans_pipe; tmp = I915_READ(TRANS_DDI_FUNC_CTL(panel_transcoder));