From: Pauli <pauli@openssl.org>
Date: Thu, 4 Nov 2021 05:05:59 +0000 (+1000)
Subject: Address Coverity 1493362 resource leak
X-Git-Tag: openssl-3.2.0-alpha1~3382
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1b4d9967a24154f1dc00f471eb843203ec7bb7d4;p=thirdparty%2Fopenssl.git

Address Coverity 1493362 resource leak

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/16962)
---

diff --git a/providers/implementations/keymgmt/mac_legacy_kmgmt.c b/providers/implementations/keymgmt/mac_legacy_kmgmt.c
index 63553996bd9..ec34a3ee713 100644
--- a/providers/implementations/keymgmt/mac_legacy_kmgmt.c
+++ b/providers/implementations/keymgmt/mac_legacy_kmgmt.c
@@ -508,6 +508,7 @@ static void *mac_gen(void *genctx, OSSL_CALLBACK *cb, void *cbarg)
      * of this can be removed and we will only support the EVP_KDF APIs.
      */
     if (!ossl_prov_cipher_copy(&key->cipher, &gctx->cipher)) {
+        ossl_mac_key_free(key);
         ERR_raise(ERR_LIB_PROV, ERR_R_INTERNAL_ERROR);
         return NULL;
     }