From: Stefan Schantl <stefan.schantl@ipfire.org>
Date: Tue, 7 Mar 2023 12:17:34 +0000 (+0100)
Subject: firewall: Silence warnings if blocklist logging is not set.
X-Git-Tag: v2.27-core174~29
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1b70ead36dfaf6541677e4ac5d05867273eaa265;p=ipfire-2.x.git

firewall: Silence warnings if blocklist logging is not set.

Reference: #12979.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---

diff --git a/config/firewall/rules.pl b/config/firewall/rules.pl
index 1b628df169..80985ca530 100644
--- a/config/firewall/rules.pl
+++ b/config/firewall/rules.pl
@@ -761,7 +761,7 @@ sub ipblocklist () {
 			}
 
 			# Check if logging is enabled.
-			if($blocklistsettings{'LOGGING'} eq "on") {
+			if($blocklistsettings{'LOGGING'}) && ($blocklistsettings{'LOGGING'} eq "on")) {
 				# Create logging rule.
 				run("$IPTABLES -A ${blocklist}_DROP -j LOG -m limit --limit 10/second --log-prefix \"BLKLST_$blocklist \"");
 			}