From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 16 Mar 2021 00:56:07 +0000 (-0700)
Subject: cocci: allow xcalloc(1, size)
X-Git-Tag: v2.31.1~5^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1c57cc70ec26529a26392539fc888486bb89b7fd;p=thirdparty%2Fgit.git

cocci: allow xcalloc(1, size)

Allocating a pre-cleared single element is quite common and it is
misleading to use CALLOC_ARRAY(); these allocations that would be
affected without this change are not allocating an array.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/contrib/coccinelle/array.cocci b/contrib/coccinelle/array.cocci
index 9a17d2a121..9a4f00cb1b 100644
--- a/contrib/coccinelle/array.cocci
+++ b/contrib/coccinelle/array.cocci
@@ -92,7 +92,7 @@ expression n;
 @@
 type T;
 T *ptr;
-expression n;
+expression n != 1;
 @@
 - ptr = xcalloc(n, \( sizeof(*ptr) \| sizeof(T) \) )
 + CALLOC_ARRAY(ptr, n)