From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Tue, 19 Apr 2022 08:42:05 +0000 (+0300)
Subject: auth: auth_worker_call() - Return void instead of the connection
X-Git-Tag: 2.3.19~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1c6c3c320d932a64a3fb048484fd2c163fa8aa46;p=thirdparty%2Fdovecot%2Fcore.git

auth: auth_worker_call() - Return void instead of the connection

The return value is no longer necessary, and it most likely would just be
used wrong.
---

diff --git a/src/auth/auth-worker-server.c b/src/auth/auth-worker-server.c
index 1661752828..41b2b2bb48 100644
--- a/src/auth/auth-worker-server.c
+++ b/src/auth/auth-worker-server.c
@@ -442,9 +442,8 @@ static void worker_input_resume(struct auth_worker_connection *conn)
 	worker_input(conn);
 }
 
-struct auth_worker_connection *
-auth_worker_call(pool_t pool, const char *username, const char *data,
-		 auth_worker_callback_t *callback, void *context)
+void auth_worker_call(pool_t pool, const char *username, const char *data,
+		      auth_worker_callback_t *callback, void *context)
 {
 	struct auth_worker_connection *conn;
 	struct auth_worker_request *request;
@@ -474,7 +473,6 @@ auth_worker_call(pool_t pool, const char *username, const char *data,
 		/* reached the limit, queue the request */
 		aqueue_append(worker_request_queue, &request);
 	}
-	return conn;
 }
 
 void auth_worker_server_resume_input(struct auth_worker_connection *conn)
diff --git a/src/auth/auth-worker-server.h b/src/auth/auth-worker-server.h
index 6b1b241446..d2a30634a3 100644
--- a/src/auth/auth-worker-server.h
+++ b/src/auth/auth-worker-server.h
@@ -8,9 +8,8 @@ struct auth_worker_connection;
 typedef bool auth_worker_callback_t(struct auth_worker_connection *conn,
 				    const char *reply, void *context);
 
-struct auth_worker_connection * ATTR_NOWARN_UNUSED_RESULT
-auth_worker_call(pool_t pool, const char *username, const char *data,
-		 auth_worker_callback_t *callback, void *context);
+void auth_worker_call(pool_t pool, const char *username, const char *data,
+		      auth_worker_callback_t *callback, void *context);
 void auth_worker_server_resume_input(struct auth_worker_connection *conn);
 
 void auth_worker_server_init(void);