From: Andres Freund <andres@anarazel.de>
Date: Fri, 21 Jan 2022 19:22:55 +0000 (-0800)
Subject: fsync pg_logical/mappings in CheckPointLogicalRewriteHeap().
X-Git-Tag: REL_12_10~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1c6d055ba77a5b600496a81bbaafaeb064d1cf2d;p=thirdparty%2Fpostgresql.git

fsync pg_logical/mappings in CheckPointLogicalRewriteHeap().

While individual logical rewrite files were synced to disk, the directory was
not. On some filesystems that could lead to loosing directory entries after a
crash.

Reported-By: Tom Lane <tgl@sss.pgh.pa.us>
Author: Nathan Bossart <bossartn@amazon.com>
Discussion: https://postgr.es/m/867F2E29-2782-4869-970E-B984C6D35A8F@amazon.com
Backpatch: 10-
---

diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c
index 335e29f8fa9..489c72582d3 100644
--- a/src/backend/access/heap/rewriteheap.c
+++ b/src/backend/access/heap/rewriteheap.c
@@ -1312,4 +1312,7 @@ CheckPointLogicalRewriteHeap(void)
 		}
 	}
 	FreeDir(mappings_dir);
+
+	/* persist directory entries to disk */
+	fsync_fname("pg_logical/mappings", true);
 }