From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Thu, 8 Sep 2022 13:49:37 +0000 (+0200)
Subject: BUG/MINOR: h3: Crash when h3 trace verbosity is "minimal"
X-Git-Tag: v2.7-dev6~62
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1c725aa9cd0e3799d7751381aabc9862bed10aff;p=thirdparty%2Fhaproxy.git

BUG/MINOR: h3: Crash when h3 trace verbosity is "minimal"

This was due to a missing check in h3_trace() about the first argument
presence (connection) and h3_parse_settings_frm() which calls TRACE_LEAVE()
without any argument. Then this argument was dereferenced.

Must be backported to 2.6
---

diff --git a/src/h3.c b/src/h3.c
index 53372c5e3e..28656fc71c 100644
--- a/src/h3.c
+++ b/src/h3.c
@@ -1248,6 +1248,9 @@ static void h3_trace(enum trace_level level, uint64_t mask,
 	const struct qcc *qcc   = conn ? conn->ctx : NULL;
 	const struct qcs *qcs   = a2;
 
+	if (!qcc)
+		return;
+
 	if (src->verbosity > H3_VERB_CLEAN) {
 		chunk_appendf(&trace_buf, " : qcc=%p(F)", qcc);