From: Zou Wei <zou_wei@huawei.com>
Date: Tue, 11 May 2021 06:53:36 +0000 (+0800)
Subject: atm: iphase: fix possible use-after-free in ia_module_exit()
X-Git-Tag: v5.14-rc1~119^2~559
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1c72e6ab66b9598cac741ed397438a52065a8f1f;p=thirdparty%2Fkernel%2Flinux.git

atm: iphase: fix possible use-after-free in ia_module_exit()

This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.

Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index e3f5d073caa65..bc8e8d9f176b2 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -3282,7 +3282,7 @@ static void __exit ia_module_exit(void)
 {
 	pci_unregister_driver(&ia_driver);
 
-        del_timer(&ia_timer);
+	del_timer_sync(&ia_timer);
 }
 
 module_init(ia_module_init);