From: Eric Wong <e@80x24.org>
Date: Sat, 20 Sep 2025 00:04:50 +0000 (+0000)
Subject: treewide: disable warning about NoCOW on btrfs
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1c737b61528d89588c45daf47be01c37760cdf5a;p=thirdparty%2Fpublic-inbox.git

treewide: disable warning about NoCOW on btrfs

It's too noisy for tests and breaks some tests which check for
warnings when TMPDIR is btrfs.  I didn't notice this earlier
since I had TMPDIR pointed at /dev/shm on my btrfs machine.
We'll probably just make CoW the default for btrfs because the
CoW overhead with --split-shards on initial index is "only" 100%
or so...
---

diff --git a/lib/PublicInbox/Syscall.pm b/lib/PublicInbox/Syscall.pm
index e65c3301d..3a46dd490 100644
--- a/lib/PublicInbox/Syscall.pm
+++ b/lib/PublicInbox/Syscall.pm
@@ -491,12 +491,7 @@ sub yesdatacow_fh ($) {
 sub nodatacow_dir ($) {
 	my ($f) = @_;
 	if (open my $fh, '<', $f) {
-		my $rc = nodatacow_fh($fh); # returns "0 but true" on success
-		$rc && $rc == 0 and warn <<EOM;
-W: Disabling copy-on-write (CoW) on `$f'
-W: to avoid pathological slowdowns.  Data corruption may occur on unclean
-W: shutdowns, especially if using any form of BTRFS RAID.
-EOM
+		return nodatacow_fh($fh); # returns "0 but true" on success
 	}
 }