From: Ian Lance Taylor <ian@airs.com>
Date: Mon, 3 Apr 2000 19:19:52 +0000 (+0000)
Subject: 2000-04-03  H.J. Lu  <hjl@gnu.org>
X-Git-Tag: binutils-2_10~73
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1c804b1e0fe0bff3252df83c4cc5476b0ade7945;p=thirdparty%2Fbinutils-gdb.git

2000-04-03  H.J. Lu  <hjl@gnu.org>

	* cache.c (bfd_open_file): Unlink the output file only if
	it has none zero size.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 82f7eb544d8..6fba1475ff6 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2000-04-03  H.J. Lu  <hjl@gnu.org>
+
+	* cache.c (bfd_open_file): Unlink the output file only if
+	it has none zero size.
+
 2000-03-31  Thomas de Lellis  <tdel@wrs.com>
 
 	* srec.c : Set CHUNK size to 16 bytes to prevent download failures
diff --git a/bfd/cache.c b/bfd/cache.c
index b28de4bc4b9..ad3140e1ed7 100644
--- a/bfd/cache.c
+++ b/bfd/cache.c
@@ -285,10 +285,25 @@ bfd_open_file (abfd)
 	}
       else
 	{
-	  /* Create the file.  Unlink it first, for the convenience of
-             operating systems which worry about overwriting running
-             binaries.  */
-	  unlink (abfd->filename);
+	  /* Create the file.
+
+	     Some operating systems won't let us overwrite a running
+	     binary.  For them, we want to unlink the file first.
+
+	     However, gcc 2.95 will create temporary files using
+	     O_EXCL and tight permissions to prevent other users from
+	     substituting other .o files during the compilation.  gcc
+	     will then tell the assembler to use the newly created
+	     file as an output file.  If we unlink the file here, we
+	     open a brief window when another user could still
+	     substitute a file.
+
+	     So we unlink the output file if and only if it has
+	     non-zero size.  */
+	  struct stat s;
+
+	  if (stat (abfd->filename, &s) == 0 && s.st_size != 0)
+	    unlink (abfd->filename);
 	  abfd->iostream = (PTR) fopen (abfd->filename, FOPEN_WB);
 	  abfd->opened_once = true;
 	}