From: Andi Kleen <ak@linux.intel.com>
Date: Tue, 30 Jan 2024 18:55:52 +0000 (-0800)
Subject: perf report: Prevent segfault with --no-parent
X-Git-Tag: v6.9-rc1~108^2~122
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1c84b47f99ea7ab7a76a785edd29e14977e1ecd0;p=thirdparty%2Fkernel%2Flinux.git

perf report: Prevent segfault with --no-parent

Prevent a perf report segfault with the (non sensical) --no-parent
option

Signed-off-By: Andi Kleen <ak@linux.intel.com>
Acked-by: Namhyung <namhyung@kernel.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240130185552.150578-1-ak@linux.intel.com
---

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 30254eb637099..92a1bd695e8aa 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -3372,7 +3372,7 @@ int sort_dimension__add(struct perf_hpp_list *list, const char *tok,
 				sort_dimension_add_dynamic_header(sd);
 		}
 
-		if (sd->entry == &sort_parent) {
+		if (sd->entry == &sort_parent && parent_pattern) {
 			int ret = regcomp(&parent_regex, parent_pattern, REG_EXTENDED);
 			if (ret) {
 				char err[BUFSIZ];