From: René Scharfe Date: Sun, 23 Feb 2025 08:26:04 +0000 (+0100) Subject: commit: avoid parent list buildup in clear_commit_marks_many() X-Git-Tag: v2.49.0-rc1~11^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1ca727f230d83db20952f8ae7ce2f1749d744334;p=thirdparty%2Fgit.git commit: avoid parent list buildup in clear_commit_marks_many() clear_commit_marks_1() clears the marks of the first parent and its first parent and so on, and saves the higher numbered parents in a list for later. There is no benefit in keeping that list growing with each handled commit. Clear it after each run to reduce peak memory usage. Signed-off-by: René Scharfe Signed-off-by: Junio C Hamano --- diff --git a/commit.c b/commit.c index 540660359d..6efdb03997 100644 --- a/commit.c +++ b/commit.c @@ -780,14 +780,14 @@ static void clear_commit_marks_1(struct commit_list **plist, void clear_commit_marks_many(size_t nr, struct commit **commit, unsigned int mark) { - struct commit_list *list = NULL; - for (size_t i = 0; i < nr; i++) { + struct commit_list *list = NULL; + clear_commit_marks_1(&list, *commit, mark); + while (list) + clear_commit_marks_1(&list, pop_commit(&list), mark); commit++; } - while (list) - clear_commit_marks_1(&list, pop_commit(&list), mark); } void clear_commit_marks(struct commit *commit, unsigned int mark)