From: Lukas Bulwahn Date: Thu, 11 Apr 2019 03:53:52 +0000 (+0200) Subject: fs: drop unused fput_atomic definition X-Git-Tag: v5.2-rc1~140^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1caf7a70a93f81fad622131e34ce68d131a71064;p=thirdparty%2Fkernel%2Flinux.git fs: drop unused fput_atomic definition commit d7065da03822 ("get rid of the magic around f_count in aio") added fput_atomic to include/linux/fs.h, motivated by its use in __aio_put_req() in fs/aio.c. Later, commit 3ffa3c0e3f6e ("aio: now fput() is OK from interrupt context; get rid of manual delayed __fput()") removed the only use of fput_atomic in __aio_put_req(), but did not remove the since then unused fput_atomic definition in include/linux/fs.h. We curate this now and finally remove the unused definition. This issue was identified during a code review due to a coccinelle warning from the atomic_as_refcounter.cocci rule pointing to the use of atomic_t in fput_atomic. Suggested-by: Krystian Radlak Signed-off-by: Lukas Bulwahn Signed-off-by: Al Viro --- diff --git a/include/linux/fs.h b/include/linux/fs.h index dd28e76790891..79b2f43b945d7 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -969,7 +969,6 @@ static inline struct file *get_file(struct file *f) #define get_file_rcu_many(x, cnt) \ atomic_long_add_unless(&(x)->f_count, (cnt), 0) #define get_file_rcu(x) get_file_rcu_many((x), 1) -#define fput_atomic(x) atomic_long_add_unless(&(x)->f_count, -1, 1) #define file_count(x) atomic_long_read(&(x)->f_count) #define MAX_NON_LFS ((1UL<<31) - 1)