From: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Date: Fri, 24 Jun 2022 07:35:05 +0000 (+0800)
Subject: fuzz/asn1.c: Add check for ASN1_item_i2d
X-Git-Tag: openssl-3.2.0-alpha1~2471
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1cb35ce06a968dc82e7cd9502ecce8e89eca9580;p=thirdparty%2Fopenssl.git

fuzz/asn1.c: Add check for ASN1_item_i2d

As the potential failure of the ASN1_item_i2d,
it should be better to check the return value.

Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18647)
---

diff --git a/fuzz/asn1.c b/fuzz/asn1.c
index 69978cd0543..ee602a08a3d 100644
--- a/fuzz/asn1.c
+++ b/fuzz/asn1.c
@@ -317,8 +317,9 @@ int FuzzerTestOneInput(const uint8_t *buf, size_t len)
                 ASN1_item_print(bio, o, 4, i, pctx);
                 BIO_free(bio);
             }
-            ASN1_item_i2d(o, &der, i);
-            OPENSSL_free(der);
+            if (ASN1_item_i2d(o, &der, i) > 0) {
+                OPENSSL_free(der);
+            }
             ASN1_item_free(o, i);
         }
     }