From: Shuah Khan <skhan@linuxfoundation.org>
Date: Tue, 6 Apr 2021 23:02:28 +0000 (-0600)
Subject: ath10k: Fix ath10k_wmi_tlv_op_pull_peer_stats_info() unlock without lock
X-Git-Tag: v5.10.37~42
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1cce33fe59f095c6198de32e5fcda36e703dfddb;p=thirdparty%2Fkernel%2Fstable.git

ath10k: Fix ath10k_wmi_tlv_op_pull_peer_stats_info() unlock without lock

[ Upstream commit eaaf52e4b866f265eb791897d622961293fd48c1 ]

ath10k_wmi_tlv_op_pull_peer_stats_info() could try to unlock RCU lock
winthout locking it first when peer reason doesn't match the valid
cases for this function.

Add a default case to return without unlocking.

Fixes: 09078368d516 ("ath10k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()")
Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210406230228.31301-1-skhan@linuxfoundation.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
index e7072fc4f487a..4f2fbc610d798 100644
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
@@ -592,6 +592,9 @@ static void ath10k_wmi_event_tdls_peer(struct ath10k *ar, struct sk_buff *skb)
 					GFP_ATOMIC
 					);
 		break;
+	default:
+		kfree(tb);
+		return;
 	}
 
 exit: