From: Jukka Kurkela Date: Thu, 31 Oct 2019 22:13:42 +0000 (+0200) Subject: Backward compatible default `fill` for radar charts (#6655) X-Git-Tag: v2.9.3~5 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1cce8a54c0503b8381226aab803bdf556b521779;p=thirdparty%2FChart.js.git Backward compatible default `fill` for radar charts (#6655) * Backward compatible fill behavior for radar --- diff --git a/src/controllers/controller.radar.js b/src/controllers/controller.radar.js index 803c7fb7f..dffe29e15 100644 --- a/src/controllers/controller.radar.js +++ b/src/controllers/controller.radar.js @@ -14,6 +14,7 @@ defaults._set('radar', { }, elements: { line: { + fill: 'start', tension: 0 // no bezier in radar } } diff --git a/test/fixtures/controller.radar/backgroundColor/scriptable.js b/test/fixtures/controller.radar/backgroundColor/scriptable.js index 4c714a451..be2a29e76 100644 --- a/test/fixtures/controller.radar/backgroundColor/scriptable.js +++ b/test/fixtures/controller.radar/backgroundColor/scriptable.js @@ -25,6 +25,7 @@ module.exports = { title: false, elements: { line: { + fill: true, backgroundColor: function(ctx) { var index = (ctx.dataIndex === undefined ? ctx.datasetIndex : ctx.dataIndex); return index === 0 ? '#ff0000' diff --git a/test/fixtures/controller.radar/backgroundColor/value.js b/test/fixtures/controller.radar/backgroundColor/value.js index d9347ee5d..dd118470d 100644 --- a/test/fixtures/controller.radar/backgroundColor/value.js +++ b/test/fixtures/controller.radar/backgroundColor/value.js @@ -20,6 +20,7 @@ module.exports = { title: false, elements: { line: { + fill: true, backgroundColor: '#00ff00' }, point: { diff --git a/test/fixtures/controller.radar/borderDash/scriptable.js b/test/fixtures/controller.radar/borderDash/scriptable.js index 0bee9a8a6..8548c88e8 100644 --- a/test/fixtures/controller.radar/borderDash/scriptable.js +++ b/test/fixtures/controller.radar/borderDash/scriptable.js @@ -22,6 +22,7 @@ module.exports = { title: false, elements: { line: { + fill: true, borderColor: '#00ff00', borderDash: function(ctx) { return ctx.datasetIndex === 0 ? [5] : [10];