From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 1 Jul 2015 11:13:54 +0000 (+0200)
Subject: qapi: Reject -p arguments that break qapi-event.py
X-Git-Tag: v2.5.0-rc0~155^2~28
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1cf47a15f18312436c7fa2d97be5fbe6df0292f5;p=thirdparty%2Fqemu.git

qapi: Reject -p arguments that break qapi-event.py

qapi-event.py breaks when you ask for a funny prefix like '@'.
Protect it.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---

diff --git a/scripts/qapi.py b/scripts/qapi.py
index ba11c54a920..bc3f4d3164e 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -1003,6 +1003,12 @@ def parse_command_line(extra_options = "", extra_long_options = []):
     for oa in opts:
         o, a = oa
         if o in ("-p", "--prefix"):
+            match = re.match('([A-Za-z_.-][A-Za-z0-9_.-]*)?', a)
+            if match.end() != len(a):
+                print >>sys.stderr, \
+                    "%s: 'funny character '%s' in argument of --prefix" \
+                    % (sys.argv[0], a[match.end()])
+                sys.exit(1)
             prefix = a
         elif o in ("-o", "--output-dir"):
             output_dir = a + "/"