From: Michal Simek <michal.simek@xilinx.com>
Date: Tue, 16 Apr 2019 06:08:21 +0000 (+0200)
Subject: cmd: fru: Simplify do_fru_capture()
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1cf538f8323d5613ae908844d35f4314e7534296;p=thirdparty%2Fu-boot.git

cmd: fru: Simplify do_fru_capture()

Remove ret and check already recorded maximum number of args via
cmdtp->maxargs.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

diff --git a/cmd/fru.c b/cmd/fru.c
index b8efaad2681..5e3363ec261 100644
--- a/cmd/fru.c
+++ b/cmd/fru.c
@@ -14,18 +14,15 @@ static int do_fru_capture(cmd_tbl_t *cmdtp, int flag, int argc,
 {
 	unsigned long addr;
 	char *endp;
-	int ret;
 
-	if (argc < 3)
+	if (argc < cmdtp->maxargs)
 		return CMD_RET_USAGE;
 
 	addr = simple_strtoul(argv[2], &endp, 16);
-	if (*argv[1] == 0 || *endp != 0)
+	if (*argv[1] == 0 || *endp != 0) /* FIXME */
 		return -1;
 
-	ret = fru_capture(addr);
-
-	return ret;
+	return fru_capture(addr);
 }
 
 static int do_fru_display(cmd_tbl_t *cmdtp, int flag, int argc,