From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 18 Feb 2021 00:07:20 +0000 (+0100)
Subject: grep/pcre2: drop needless assignment to NULL
X-Git-Tag: v2.32.0-rc0~148^2~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1cfc5a850c3962f341accb15cef6d09c21bbbdee;p=thirdparty%2Fgit.git

grep/pcre2: drop needless assignment to NULL

Remove a redundant assignment of pcre2_compile_context dating back to
my 94da9193a6e (grep: add support for PCRE v2, 2017-06-01).

In create_grep_pat() we xcalloc() the "grep_pat" struct, so there's no
need to NULL out individual members here.

I think this was probably something left over from an earlier
development version of mine.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/grep.c b/grep.c
index 816e23f17e..f27c5de7f5 100644
--- a/grep.c
+++ b/grep.c
@@ -373,8 +373,6 @@ static void compile_pcre2_pattern(struct grep_pat *p, const struct grep_opt *opt
 	int patinforet;
 	size_t jitsizearg;
 
-	p->pcre2_compile_context = NULL;
-
 	/* pcre2_global_context is initialized in append_grep_pattern */
 	if (opt->ignore_case) {
 		if (!opt->ignore_locale && has_non_ascii(p->pattern)) {