From: Richard Levitte <levitte@openssl.org>
Date: Thu, 18 Sep 2025 11:22:47 +0000 (+0200)
Subject: Add unsupported features in NOTES-C99.md: complex.h and variable length array
X-Git-Tag: openssl-3.6.0~40
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1d35a9e8709a278b068837e238ad70dc6327e7ca;p=thirdparty%2Fopenssl.git

Add unsupported features in NOTES-C99.md: complex.h and variable length array

Resolves: https://github.com/openssl/openssl/issues/28598

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from https://github.com/openssl/openssl/pull/28602)

(cherry picked from commit 4a0d4a5c3a5970591b2c9ac645125c1ec448d8e9)
---

diff --git a/NOTES-C99.md b/NOTES-C99.md
index ad3be43b619..47b153a88da 100644
--- a/NOTES-C99.md
+++ b/NOTES-C99.md
@@ -20,3 +20,16 @@ The list here is going to be updated by features we either
 The list of C-99 features we don't support in OpenSSL project follows:
 
    - do not use `//` for comments, stick to `/* ... */`
+
+   - do not use `<complex.h>`. MSVC doesn't quite implement it to standard.
+
+   - do not use variable length arrays, i.e. arrays where the size is
+     determined by another variable.  MSVC doesn't implement it at all.
+     For clarity, this is an example of such an array:
+
+     ``` C
+     int fun(size_t n)
+     {
+         char s[n]; /* variable size array */
+         ...
+     ```