From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 13 Dec 2004 00:33:18 +0000 (+0000)
Subject: Avoid generating excess (and illegal) parentheses around an aliased JOIN
X-Git-Tag: REL7_4_7~18
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1d3ee97a3c54713829cdd7e4c404aedb6b6e5b42;p=thirdparty%2Fpostgresql.git

Avoid generating excess (and illegal) parentheses around an aliased JOIN
in prettyprint mode.  Andreas Pflug
---

diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c
index 50c91ad4bce..42c5bd8ca5a 100644
--- a/src/backend/utils/adt/ruleutils.c
+++ b/src/backend/utils/adt/ruleutils.c
@@ -3,7 +3,7 @@
  *				back to source text
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.157.2.2 2004/07/06 04:50:54 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.157.2.3 2004/12/13 00:33:18 tgl Exp $
  *
  *	  This software is copyrighted by Jan Wieck - Hamburg.
  *
@@ -3816,7 +3816,8 @@ get_from_clause_item(Node *jtnode, Query *query, deparse_context *context)
 		bool		need_paren_on_right;
 
 		need_paren_on_right = PRETTY_PAREN(context) &&
-			!IsA(j->rarg, RangeTblRef);
+		  !IsA(j->rarg, RangeTblRef) && 
+		  !(IsA(j->rarg, JoinExpr) && ((JoinExpr*)j->rarg)->alias != NULL);
 
 		if (!PRETTY_PAREN(context) || j->alias != NULL)
 			appendStringInfoChar(buf, '(');