From: Guy Yur Date: Mon, 1 Jun 2015 19:51:13 +0000 (+0200) Subject: Fix --redirect-private in --dev tap mode. X-Git-Tag: v2.4_alpha1~286 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1e2b229e5140b784820906feb8446e47c1ecc62e;p=thirdparty%2Fopenvpn.git Fix --redirect-private in --dev tap mode. When specifying redirect-private option and not specifying route-gateway or ifconfig options, OpenVPN fails to add the route to the remote host with the following message: NOTE: unable to redirect default gateway -- VPN gateway parameter (--route-gateway or --ifconfig) is missing In redirect_default_route_to_vpn() the check for remote endpoint happens even though it is not used by redirect-private - make check conditional on RG_REROUTE_GW (= --redirect-gateway). Trac #261 Acked-by: Gert Doering Message-Id: <20150531120327.GE382@greenie.muc.de> URL: http://article.gmane.org/gmane.network.openvpn.devel/9761 Signed-off-by: Gert Doering --- diff --git a/src/openvpn/route.c b/src/openvpn/route.c index a349ac980..ee7c0def8 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -808,7 +808,7 @@ redirect_default_route_to_vpn (struct route_list *rl, const struct tuntap *tt, u if ( rl && rl->flags & RG_ENABLE ) { - if (!(rl->spec.flags & RTSA_REMOTE_ENDPOINT)) + if (!(rl->spec.flags & RTSA_REMOTE_ENDPOINT) && (rl->flags & RG_REROUTE_GW)) { msg (M_WARN, "%s VPN gateway parameter (--route-gateway or --ifconfig) is missing", err); }