From: Matthias Kaehlcke <mka@chromium.org>
Date: Mon, 27 Aug 2018 21:14:53 +0000 (-0700)
Subject: iio: adc: qcom-spmi-adc5: Verify channel numbers from DT
X-Git-Tag: v4.20-rc1~72^2~380^2~14
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1e46774fec4b54adbd7cc15f1931e9df98664530;p=thirdparty%2Flinux.git

iio: adc: qcom-spmi-adc5: Verify channel numbers from DT

The driver only defines a subset of all possible ADC channels. Channel
numbers read from the device tree are accepted as long as they don't
exceed a max value, even when no channel definition exists. Add a
check to abort initialization in this case.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---

diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
index 1f9298a5c83d4..f9af6b082916b 100644
--- a/drivers/iio/adc/qcom-spmi-adc5.c
+++ b/drivers/iio/adc/qcom-spmi-adc5.c
@@ -519,7 +519,8 @@ static int adc5_get_dt_channel_data(struct adc5_chip *adc,
 		return ret;
 	}
 
-	if (chan > ADC5_PARALLEL_ISENSE_VBAT_IDATA) {
+	if (chan > ADC5_PARALLEL_ISENSE_VBAT_IDATA ||
+	    !data->adc_chans[chan].datasheet_name) {
 		dev_err(dev, "%s invalid channel number %d\n", name, chan);
 		return -EINVAL;
 	}