From: Steffan Karger <steffan@karger.me>
Date: Fri, 9 Oct 2020 13:46:03 +0000 (+0200)
Subject: networking_iproute2: fix memory leak in net_iface_mtu_set()
X-Git-Tag: v2.6_beta1~671
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1e6e083e8888042d58f9541bf74d343d52fc5681;p=thirdparty%2Fopenvpn.git

networking_iproute2: fix memory leak in net_iface_mtu_set()

ASAN yelled at me that someone forgot to call argv_free(). Fix that.

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: Antonio Quartulli <a@unstable.cc>
Message-Id: <20201009134603.36263-1-steffan@karger.me>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21189.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
---

diff --git a/src/openvpn/networking_iproute2.c b/src/openvpn/networking_iproute2.c
index f3b9c6144..3b460527c 100644
--- a/src/openvpn/networking_iproute2.c
+++ b/src/openvpn/networking_iproute2.c
@@ -88,6 +88,8 @@ net_iface_mtu_set(openvpn_net_ctx_t *ctx, const char *iface, uint32_t mtu)
     argv_msg(M_INFO, &argv);
     openvpn_execve_check(&argv, ctx->es, S_FATAL, "Linux ip link set failed");
 
+    argv_free(&argv);
+
     return 0;
 }