From: Dan Williams <dan.j.williams@intel.com>
Date: Sun, 28 Sep 2008 19:12:07 +0000 (-0700)
Subject: imsm: fix mpb_size calculation in write_super_imsm
X-Git-Tag: mdadm-3.0-devel2~90
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1ee1e9fc62e74f56ca6786690f4247c4c7a8c1bb;p=thirdparty%2Fmdadm.git

imsm: fix mpb_size calculation in write_super_imsm

Spotted a thinko... raid devices are dynamically sized, disks are not.
The space for disks is always mpb->num_disks * sizeof(struct imsm_disk).

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---

diff --git a/super-intel.c b/super-intel.c
index 80427e4a..19c964f8 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -1854,13 +1854,12 @@ static int write_super_imsm(struct intel_super *super, int doclose)
 	generation++;
 	mpb->generation_num = __cpu_to_le32(generation);
 
+	mpb_size += sizeof(struct imsm_disk) * mpb->num_disks;
 	for (d = super->disks; d; d = d->next) {
 		if (d->index == -1)
 			spares++;
-		else {
+		else
 			mpb->disk[d->index] = d->disk;
-			mpb_size += sizeof(struct imsm_disk);
-		}
 	}
 
 	for (i = 0; i < mpb->num_raid_devs; i++) {