From: William Lallemand <wlallemand@haproxy.org>
Date: Sun, 30 Oct 2022 18:00:06 +0000 (+0100)
Subject: CLEANUP: ssl: remove dead code in ssl_sock_load_pem_into_ckch()
X-Git-Tag: v2.7-dev9~122
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1ef1b859d0ddb9ad68aa4e2b861a37387815a5e1;p=thirdparty%2Fhaproxy.git

CLEANUP: ssl: remove dead code in ssl_sock_load_pem_into_ckch()

Commit 432cd1a ("MEDIUM: ssl: be stricter about chain error")
introduced some dead code, let's remove it.

Should fix issue #1909.
---

diff --git a/src/ssl_ckch.c b/src/ssl_ckch.c
index 1df6b967fc..9fcbbafabb 100644
--- a/src/ssl_ckch.c
+++ b/src/ssl_ckch.c
@@ -626,8 +626,6 @@ int ssl_sock_load_pem_into_ckch(const char *path, char *buf, struct cert_key_and
 	while ((ca = PEM_read_bio_X509(in, NULL, NULL, NULL))) {
 		if (chain == NULL)
 			chain = sk_X509_new_null();
-		if (ca == NULL)
-			break;
 		if (!sk_X509_push(chain, ca)) {
 			X509_free(ca);
 			break;