From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Tue, 3 Aug 2021 17:38:13 +0000 (+0300)
Subject: lib-storage: mailbox_get_expunge*() - Fix assert-crash on index corruption
X-Git-Tag: 2.3.18~271
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1efd4a176562bc12e4f83703ae767f43b910c2b9;p=thirdparty%2Fdovecot%2Fcore.git

lib-storage: mailbox_get_expunge*() - Fix assert-crash on index corruption

This happened in the very unlikely situation that indexes became corrupted
between two mail_transaction_log_view_set() calls.

Fixes:
Panic: file mailbox-get.c: line 112 (mailbox_get_expunges_init): assertion failed: (ret != 0)
---

diff --git a/src/lib-storage/mailbox-get.c b/src/lib-storage/mailbox-get.c
index e1c1f20163..84a14ed00e 100644
--- a/src/lib-storage/mailbox-get.c
+++ b/src/lib-storage/mailbox-get.c
@@ -109,7 +109,6 @@ mailbox_get_expunges_init(struct mailbox *box, uint64_t prev_modseq,
 							    box->view->log_file_head_seq,
 							    box->view->log_file_head_offset,
 							    &reset, &reason);
-			i_assert(ret != 0);
 		}
 		*modseq_too_old_r = TRUE;
 	}