From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 18 Jul 2014 09:07:01 +0000 (+0200)
Subject: qemu: snapshot: Forbid snapshots of iSCSI passthrough devices
X-Git-Tag: v1.2.7-rc1~71
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1f4933f0f40446136b290694a276cf29df567dfe;p=thirdparty%2Flibvirt.git

qemu: snapshot: Forbid snapshots of iSCSI passthrough devices

As with the local SCSI passthrough devicesm qemu can't support snapshots
on those as the block ops are handled by the device. This is also true
for iSCSI backing of the disk. Remove the check for the local block
device and just forbid snapshot when the disk is of type 'lun'.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1073368
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 33541d34f7..3096688fad 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -12434,10 +12434,7 @@ qemuDomainSnapshotPrepareDiskExternalBackingInactive(virDomainDiskDefPtr disk)
 static int
 qemuDomainSnapshotPrepareDiskExternalBackingActive(virDomainDiskDefPtr disk)
 {
-    int actualType = virStorageSourceGetActualType(disk->src);
-
-    if (actualType == VIR_STORAGE_TYPE_BLOCK &&
-        disk->device == VIR_DOMAIN_DISK_DEVICE_LUN) {
+    if (disk->device == VIR_DOMAIN_DISK_DEVICE_LUN) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("external active snapshots are not supported on scsi "
                          "passthrough devices"));