From: Michael Tremer <michael.tremer@ipfire.org>
Date: Fri, 24 Mar 2023 15:56:07 +0000 (+0000)
Subject: transaction: Use cleanup function to remove all files from a filelist
X-Git-Tag: 0.9.29~221
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1f5bf4f85c6479a0a98888b034a0792637956891;p=pakfire.git

transaction: Use cleanup function to remove all files from a filelist

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/transaction.c b/src/libpakfire/transaction.c
index 8a2f1b4df..11cd89989 100644
--- a/src/libpakfire/transaction.c
+++ b/src/libpakfire/transaction.c
@@ -750,20 +750,10 @@ static int pakfire_transaction_erase(struct pakfire_transaction* transaction,
 	if (r)
 		goto ERROR;
 
-	const size_t length = pakfire_filelist_length(filelist);
-
-	// Delete all files
-	for (unsigned int i = 0; i < length; i++) {
-		struct pakfire_file* file = pakfire_filelist_get(filelist, i);
-
-		// Remove the file
-		r = pakfire_file_remove(file);
-		pakfire_file_unref(file);
-
-		// Break on any errors
-		if (r)
-			goto ERROR;
-	}
+	// Remove all files on the filelist
+	r = pakfire_filelist_cleanup(filelist);
+	if (r)
+		goto ERROR;
 
 	// Update the runtime linker cache after all files have been removed
 	pakfire_jail_ldconfig(transaction->pakfire);