From: Li Qiang <liqiang01@kylinos.cn>
Date: Tue, 9 Jul 2024 06:36:38 +0000 (+0800)
Subject: clk/sophgo: Using BUG() instead of unreachable() in mmux_get_parent_id()
X-Git-Tag: v6.11-rc1~109^2^4~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1f7a04a0e673c19cc10bf4039047e11367ac5735;p=thirdparty%2Fkernel%2Flinux.git

clk/sophgo: Using BUG() instead of unreachable() in mmux_get_parent_id()

In general it's a good idea to avoid using bare unreachable() because it
introduces undefined behavior in compiled code. but it caused a compilation warning,
Using BUG() instead of unreachable() to resolve compilation warnings.

Fixes the following warnings:
    drivers/clk/sophgo/clk-cv18xx-ip.o: warning: objtool: mmux_round_rate() falls through to next function bypass_div_round_rate()

Fixes: 80fd61ec46124 ("clk: sophgo: Add clock support for CV1800 SoC")
Signed-off-by: Li Qiang <liqiang01@kylinos.cn>
Link: https://lore.kernel.org/r/c8e66d51f880127549e2a3e623be6787f62b310d.1720506143.git.liqiang01@kylinos.cn
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---

diff --git a/drivers/clk/sophgo/clk-cv18xx-ip.c b/drivers/clk/sophgo/clk-cv18xx-ip.c
index 805f561725ae1..b186e64d4813e 100644
--- a/drivers/clk/sophgo/clk-cv18xx-ip.c
+++ b/drivers/clk/sophgo/clk-cv18xx-ip.c
@@ -613,7 +613,7 @@ static u8 mmux_get_parent_id(struct cv1800_clk_mmux *mmux)
 			return i;
 	}
 
-	unreachable();
+	BUG();
 }
 
 static int mmux_enable(struct clk_hw *hw)